Re: contrib/diff-highlight: stop hard-coding perl location

From: Peter Dave Hello <hsu@peterdavehello.org>
Date: Feb 22, 2016, 06:49 UTC
Message-ID: <CA+boQ6bCH35hu9GfQY_P5bNZCdJ8Knr8zQ+S41RGF0z-JamVgw@mail.gmail.com>
In-Reply-To: <CAPig+cSE77JbD9CShrxnFsDLd9DrG9L15BSecERk_Qih9CMOig@mail.gmail.com>

Hi Eric,

Thank you, is there anything I should do? Or I should just wait?

Best, Peter

2016/2/22 下午1:56於 "Eric Sunshine" <sunshine@sunshineco.com>寫道：

Show 28 quoted lines

>
> On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello
> <hsu@peterdavehello.org> wrote:
> > From: Peter Dave Hello <hsu@peterdavehello.org>
> >
> > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,
> > the util "env" can help located the "perl",
> > so that it can work on FreeBSD and other platforms.
> >
> > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
>
> Better, thanks.
>
> > ---
> >  contrib/diff-highlight/diff-highlight | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/diff-highlight/diff-highlight
> > b/contrib/diff-highlight/diff-highlight
> > index ffefc31..b57b0fd 100755
> > --- a/contrib/diff-highlight/diff-highlight
> > +++ b/contrib/diff-highlight/diff-highlight
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >
> >  use 5.008;
> >  use warnings FATAL => 'all';