Re: [PATCH] gitk: avoid hardcoded 40 character length for oid

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 11, 2021, 20:03 UTC
Message-ID: <CAPig+cQi_baTaV+Z=UJcrwS+C1dYnQ6bKEA-Bcim2VUOu8VGJA@mail.gmail.com>
In-Reply-To: <20211011195550.3355-1-carenas@gmail.com>

On Mon, Oct 11, 2021 at 3:56 PM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 17 quoted lines

> Current git could return ids larger than 40 characters if using
> SHA-256.
>
> Detect if the current repository does and set the oid_size to 64
> instead, but fallback to 40 for backward compatibility.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> diff --git a/gitk b/gitk
> @@ -12338,6 +12347,18 @@ catch {
> +if {![catch {exec git config --get extensions.objectformat} oid_type]
> +    && $oid_type eq "sha256" } {
> +    set oid_size 64
> +} else {
> +    set oid_type "sha1"
> +    set oid_size 40
> +}

Should this be using:

    git rev-parse --show-object-format

rather than `git-config`?