Re: [PATCH] gitk: avoid hardcoded 40 character length for oid

From: Carlo Arenas <carenas@gmail.com>
Date: Oct 11, 2021, 20:37 UTC
Message-ID: <CAPUEspha9Ymxaqp17JA5DaftvxeU_XmTZs089D1zb9WidYn+Pg@mail.gmail.com>
In-Reply-To: <CAPig+cQi_baTaV+Z=UJcrwS+C1dYnQ6bKEA-Bcim2VUOu8VGJA@mail.gmail.com>

On Mon, Oct 11, 2021 at 1:04 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 17 quoted lines

>
> On Mon, Oct 11, 2021 at 3:56 PM Carlo Marcelo Arenas Belón
> > diff --git a/gitk b/gitk
> > @@ -12338,6 +12347,18 @@ catch {
> > +if {![catch {exec git config --get extensions.objectformat} oid_type]
> > +    && $oid_type eq "sha256" } {
> > +    set oid_size 64
> > +} else {
> > +    set oid_type "sha1"
> > +    set oid_size 40
> > +}
>
> Should this be using:
>
>     git rev-parse --show-object-format
>
> rather than `git-config`?

definitely a better fit, will be included in the next version.

Carlo