git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: error out when relogin delay is missing

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 8, 2018, 08:08 UTC
Message-ID
<CAPig+cQejz+1ZWep31hw0pjxUoewRt+-2WATtw6PEusfvhn8EA@mail.gmail.com>
In-Reply-To
<20180207234359.31493-1-sbeller@google.com>
On Wed, Feb 7, 2018 at 6:43 PM, Stefan Beller <sbeller@google.com> wrote:
Show 13 quoted lines
> [...]
> Error out for now instead of potentially confusing the user.
> As 5453b83bdf (send-email: --batch-size to work around some SMTP
> server limit, 2017-05-21) lays out, we rather want to not have this
> interface anyway and would rather want to react on the server throttling
> dynamically.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff --git a/git-send-email.perl b/git-send-email.perl
> @@ -379,6 +379,9 @@ unless ($rc) {
> +die __("When a batch size is given, the relogin delay must be set\n")
> +       if defined $relogin_delay and not defined $batch_size;

This only makes sense is 'batch-size' is specified but not 'relogin'. If the other way around, then the error is confusing. How about this instead?

    "--batch-size and --relogin must be specified together"
...or something.
Previous: xiaoqiang zhaoNext: Stefan Beller
Message 8 of 15 in “send-email: --batch-size to work around some SMTP server limit”
  1. send-email: --batch-size to work around some SMTP server limitxiaoqiang zhao, May 21, 2017
  2. Junio C HamanoMay 22, 2017
  3. ZhaoxiangqiangMay 22, 2017
  4. send-email: have default batch size when relogin delay is givenStefan Beller, Feb 7, 2018
  5. Eric SunshineFeb 7, 2018
  6. send-email: error out when relogin delay is missingStefan Beller, Feb 7, 2018
  7. xiaoqiang zhaoFeb 8, 2018
  8. Eric SunshineFeb 8, 2018
  9. Stefan BellerFeb 8, 2018
  10. Eric SunshineFeb 8, 2018
  11. send-email: error out when relogin delay is missingStefan Beller, Feb 12, 2018
  12. Ævar Arnfjörð BjarmasonMay 22, 2017
  13. Junio C HamanoMay 23, 2017
  14. Jan ViktorinMay 23, 2017
  15. 赵小强May 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.