[PATCH] send-email: error out when relogin delay is missing
- From
Stefan Beller <sbeller@google.com>
- Date
- Feb 7, 2018, 23:43 UTC
- Message-ID
- <20180207234359.31493-1-sbeller@google.com>
- In-Reply-To
- <CAPig+cQZr=UN3KC3LnaKy=oUYd1inbtDgi_pDuhPXf9HgFOdNw@mail.gmail.com>
When the batch size is neither configured nor given on the command line, but the relogin delay is given, then the current code ignores the relogin delay setting.
This is unsafe as there was some intention when setting the batch size. One workaround would be to just assume a batch size of 1 as a default. This however may be bad UX, as then the user may wonder why it is sending slowly without apparent batching.
Error out for now instead of potentially confusing the user. As 5453b83bdf (send-email: --batch-size to work around some SMTP server limit, 2017-05-21) lays out, we rather want to not have this interface anyway and would rather want to react on the server throttling dynamically.
Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Stefan Beller <sbeller@google.com> --- git-send-email.perl | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/git-send-email.perl b/git-send-email.perl index 340b5c8482..bc0d3ade16 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -379,6 +379,9 @@ unless ($rc) { die __("Cannot run git format-patch from outside a repository\n") if $format_patch and not $repo; +die __("When a batch size is given, the relogin delay must be set\n") + if defined $relogin_delay and not defined $batch_size; + # Now, let's fill any that aren't set in with defaults: sub read_config {
-- 2.16.0.rc1.238.g530d649a79-goog