Re: [PATCH 0/1] quote: quote space

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 28, 2024, 17:05 UTC
Message-ID: <CAPig+cQe1rAN2MUFTwo7JoCt3sO2eCk_psnJL9D=Rs=Q9MWO9A@mail.gmail.com>
In-Reply-To: <20240328114038.GA1394725@coredump.intra.peff.net>

On Thu, Mar 28, 2024 at 7:40 AM Jeff King <peff@peff.net> wrote:

Show 20 quoted lines

> It looks like making the directory works fine:
>
>   # mkdir "funny "
>   # ls -ld f*
>   drwxr-xr-x 1 runneradmin None 0 Mar 28 11:01 'funny '
>
> So I suspect this isn't a bug in Git so much as we are running afoul of
> OS limitations. And that is corroborated by these:
>
>   https://superuser.com/questions/1733673/how-to-determine-if-a-file-with-a-trailing-space-exists
>   https://stackoverflow.com/questions/48439697/trailing-whitespace-in-filename
>
> There's some Win32 API magic you can do by prepending "\\?\", but I
> couldn't get it to do anything useful.  Curiously, asking Git to
> traverse itself yields another failure mode:
>
>   # git add "funny "
>   error: open("funny /empty"): No such file or directory
>   error: unable to index file 'funny /empty'
>   fatal: adding files failed

This reminded me very much of [1] which exhibited the same failure mode and was due to the same limitation(s) of the OS.

[1]: https://lore.kernel.org/git/20211209051115.52629-3-sunshine@sunshineco.com/