Re: [PATCH v2] t4126: fix "funny directory name" test on Windows (again)

From: Jeff King <peff@peff.net>
Date: Mar 29, 2024, 18:34 UTC
Message-ID: <20240329183431.GB31800@coredump.intra.peff.net>
In-Reply-To: <xmqq5xx50x8p.fsf_-_@gitster.g>

On Fri, Mar 29, 2024 at 10:21:58AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Even though "git update-index --cacheinfo" ought to be filesystem
> agnostic,
> 
>     $ git update-index --add --cacheinfo "100644,$empty_blob,funny /empty"
> 
> fails only on Windows, and this unfortunately makes the approach of
> the previous step unworkable.
> 
> Resurrect the earlier approach to give up on running the test on
> known-bad platforms.  Instead of computing a custom prerequisite,
> just use !MINGW we have used elsewhere.

Thanks, this looks good to me. You mentioned FUNNYNAMES earlier (which I forgot even existed). That would probably work in practice, but it is kind of overloaded already. I think using MINGW here gets to the point, and as you note, if some other platforms fails we'd want to hear about it.

-Peff