Re: [PATCH/RFC 0/4] Perl rewrite of Ruby git-related

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 2, 2013, 09:01 UTC
Message-ID: <CAPig+cQdcMnDKbgae6fOmQ822go4RyvrKrzOwiEEoftFHHeZKg@mail.gmail.com>
In-Reply-To: <7vobamgqqh.fsf@alter.siamese.dyndns.org>

On Mon, Jul 1, 2013 at 1:00 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> No attempt is made to answer Junio's v9 review[5], as I lack sufficient
>> insight with '-C' options to be able to respond properly.
>
> I just wanted to see if we want to allow the end user of this script
> to specify what -C level they want the underlying blame to use, or
> just a hardcoded one should suffice (and if so an explanation why).

It might indeed make sense to allow the user control over the -C level, just as the user likely should have control over other assumptions made by the script (to wit: $since = '5-years-ago'; $min_percent = 10). More fodder for future patches.

Now that I've read up more carefully on the -C option, I too wonder why git-blame and git-show are invoked with different -C levels. At the very least, I think they should be unified in this initial patch to either one or two -C's. Since the script already is quite slow, I'm leaning toward just one -C.