Re: [PATCH v2 1/2] blame: respect .git-blame-ignore-revs automatically

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 12, 2024, 06:43 UTC
Message-ID: <CAPig+cQZkBVEHmUqzmouM4A=pgpXhTPNc8cBg0rDdTN=v=hW=g@mail.gmail.com>
In-Reply-To: <CAPig+cR4WbcDDav0cdXxOMC-EDe2ipWxEzB+0C7zbFjvY_kXtg@mail.gmail.com>

On Sat, Oct 12, 2024 at 2:07 AM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> On Sat, Oct 12, 2024 at 12:38 AM Abhijeetsingh Meena via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > +       /*
> > +       * By default, add .git-blame-ignore-revs to the list of files
> > +       * containing revisions to ignore if it exists.
> > +       */
> > +       if (access(".git-blame-ignore-revs", F_OK) == 0) {
> > +               string_list_append(&ignore_revs_file_list, ".git-blame-ignore-revs");
> > +       }
>
> A couple style nits and a couple questions...

One other observation: The comment above this code block doesn't say anything that isn't already stated just as clearly by the code itself. Hence, the comment adds no value, thus should be dropped.