Re: [PATCH v2 2/2] blame: introduce --override-ignore-revs to bypass ignore revisions list
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Oct 12, 2024, 06:26 UTC
- Message-ID
- <CAPig+cQ=WGz4vmkcBR0Rk8KtQiF2vaH1PLt0-rTDvYi=z=EEUg@mail.gmail.com>
- In-Reply-To
- <CAPig+cRkp3ZrykLvgDaGnKgZNV5GiFqc5zq6ZZ-fM7RJcqxM7A@mail.gmail.com>
On Sat, Oct 12, 2024 at 2:24 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 15 quoted lines
> On Sat, Oct 12, 2024 at 12:38 AM Abhijeetsingh Meena via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > [...]
> > This patch introduces the --override-ignore-revs option (or -O),
> > which allows users to easily bypass the --ignore-revs-file
> > option, --ignore-rev option and the blame.ignoreRevsFile
> > configuration. When this option is used, git blame will completely
> > disregard all configured ignore revisions lists.
> > + OPT_BOOL('O', "override-ignore-revs", &override_ignore_revs, N_("override all configurations that exclude revisions")),
>
> We don't normally allocate a short option name ("-O" in this case)
> when introducing a new option since short option names are considered
> a valuable and limited resource. A short option name may be added
> *later* if experience shows that the option is popular enough that the
> convenience of the short option name is warranted.I forgot to mention that this patch also deserves a documentation update; otherwise how are users going to know that the new option exists?