Re: [PATCH/RFC] get_sha1: prefer 40-hex ref name over 40-hex SHA-1

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 1, 2013, 03:03 UTC
Message-ID: <CAPig+cQMN56KfcgAu5EO39aGYwL_TO8CWuHSfcwAbruzw0a88A@mail.gmail.com>
In-Reply-To: <1367377282-9862-1-git-send-email-pclouds@gmail.com>

On Tue, Apr 30, 2013 at 11:01 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 9 quoted lines

> The current behavior is inconsistent when passing SHA-1 to get_sha1.
> If it's a short sha-1, refs take precedence. "git rev-parse 1234" will
> resolve refs/heads/1234 if exists even if there is an unambiguous
> SHA-1 starting with 1234. However if it's full SHA-1, the SHA-1 takes
> precedence and refs with the same name are ignored.
>
> The former makes more sense than the latter. This patch makes git
> check for 40-hex ref names before consider it SHA-1. In future, we may
> want to warn ambiguity between refs and SHA-1 (for both full and short

s/warn/warn about/

> SHA-1).
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>