Re: [PATCH/RFC] get_sha1: prefer 40-hex ref name over 40-hex SHA-1

From: Thomas Rast <trast@inf.ethz.ch>
Date: May 2, 2013, 08:55 UTC
Message-ID: <87r4hpu5f8.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1367377282-9862-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 14 quoted lines

> +test_expect_success 'rev-parse 20-hex ref' '
> +	REF=`git rev-parse HEAD` &&
> +	VAL=`echo| git commit-tree 4b825dc642cb6eb9a060e54bf8d69288fbee4904` &&
> +	git update-ref refs/heads/$REF $VAL &&
> +	test `git rev-parse $REF` = $VAL
> +'
> +
> +test_expect_success 'rev-parse ambiguous 20-hex ref' '
> +	REF=`git rev-parse HEAD` &&
> +	VAL=`echo| git commit-tree -p HEAD 4b825dc642cb6eb9a060e54bf8d69288fbee4904` &&
> +	git update-ref refs/tags/$REF $VAL &&
> +	test `git rev-parse $REF 2>err` = $VAL &&
> +	grep "refname.*ambiguous" err
> +'

Shouldn't these say s/20-hex/40-hex/?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch