git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/8] diff.c: rewrite emit_line_0 more understandably

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 28, 2018, 06:33 UTC
Message-ID
<CAPig+cQHPCeOigVoe1jOMuvKGTV-UgdNCTk+OyD1sBuGQJADRg@mail.gmail.com>
In-Reply-To
<20180728030448.192177-9-sbeller@google.com>
On Fri, Jul 27, 2018 at 11:05 PM Stefan Beller <sbeller@google.com> wrote:
Show 8 quoted lines
> emit_line_0 has no nested conditions, but puts out all its arguments
> (if set) in order. There is still a slight confusion with set
> and set_sign, but let's defer that to a later patch.
>
> 'first' used be output always no matter if it was 0, but that got lost
> got lost at e8c285c4f9c (diff: add an internal option to dual-color
> diffs of diffs, 2018-07-21), as there we broadened the meaning of 'first'
> to also signal an early return.
s/used be/used to be/
redundant "got lost"
Show 5 quoted lines
> The change in 'emit_line' makes sure that 'first' is never content, but
> always under our control, a sign or special character in the beginning
> of the line (or 0, in which case we ignore it).
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
Previous: Stefan BellerNext: Stefan Beller
Message 13 of 26 in “Add color test for range-diff, simplify diff.c”
  1. 0/8 Add color test for range-diff, simplify diff.cStefan Beller, Jul 28, 2018
  2. 1/8 test_decode_color: understand FAINT and ITALICStefan Beller, Jul 28, 2018
  3. 2/8 t3206: add color test for range-diff --dual-colorStefan Beller, Jul 28, 2018
  4. Eric SunshineJul 28, 2018
  5. Stefan BellerJul 30, 2018
  6. 3/8 diff.c: simplify caller of emit_line_0Stefan Beller, Jul 28, 2018
  7. 4/8 diff.c: reorder arguments for emit_line_ws_markupStefan Beller, Jul 28, 2018
  8. 5/8 diff.c: add set_sign to emit_line_0Stefan Beller, Jul 28, 2018
  9. Eric SunshineJul 28, 2018
  10. 6/8 diff: use emit_line_0 once per lineStefan Beller, Jul 28, 2018
  11. 7/8 diff.c: compute reverse locally in emit_line_0Stefan Beller, Jul 28, 2018
  12. 8/8 diff.c: rewrite emit_line_0 more understandablyStefan Beller, Jul 28, 2018
  13. Eric SunshineJul 28, 2018
  14. 0/8 Add color test for range-diff, simplify diff.cStefan Beller, Jul 31, 2018
  15. 1/8 test_decode_color: understand FAINT and ITALICStefan Beller, Jul 31, 2018
  16. 2/8 t3206: add color test for range-diff --dual-colorStefan Beller, Jul 31, 2018
  17. Junio C HamanoJul 31, 2018
  18. 3/8 diff.c: simplify caller of emit_line_0Stefan Beller, Jul 31, 2018
  19. 4/8 diff.c: reorder arguments for emit_line_ws_markupStefan Beller, Jul 31, 2018
  20. 5/8 diff.c: add set_sign to emit_line_0Stefan Beller, Jul 31, 2018
  21. 6/8 diff: use emit_line_0 once per lineStefan Beller, Jul 31, 2018
  22. 7/8 diff.c: compute reverse locally in emit_line_0Stefan Beller, Jul 31, 2018
  23. 8/8 diff.c: rewrite emit_line_0 more understandablyStefan Beller, Jul 31, 2018
  24. Junio C HamanoAug 1, 2018
  25. Stefan BellerAug 1, 2018
  26. Junio C HamanoAug 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.