git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/8] Add color test for range-diff, simplify diff.c

From
Stefan Beller <sbeller@google.com>
Date
Jul 28, 2018, 03:04 UTC
Message-ID
<20180728030448.192177-1-sbeller@google.com>
This is based on origin/js/range-diff (c255a588bcd) and is also available
via
  git fetch https://github.com/stefanbeller/git ws_cleanup-ontop-range-diff-2 

This adds some color testing to range-diff and then attempts to make the code in diff.c around emit_line_0 more readable.

I think we can go further bit more (by e.g. cherry-picking "ws: do not reset and set color twice" found at [1]), but that would be feature work. This series doesn't change any existing tests!

[1] https://github.com/stefanbeller/git/tree/ws_cleanup-ontop-range-diff

Thanks, Stefan

Stefan Beller (8):
  test_decode_color: understand FAINT and ITALIC
  t3206: add color test for range-diff --dual-color
  diff.c: simplify caller of emit_line_0
  diff.c: reorder arguments for emit_line_ws_markup
  diff.c: add set_sign to emit_line_0
  diff: use emit_line_0 once per line
  diff.c: compute reverse locally in emit_line_0
  diff.c: rewrite emit_line_0 more understandably
 diff.c                  | 94 +++++++++++++++++++++++------------------
 t/t3206-range-diff.sh   | 39 +++++++++++++++++
 t/test-lib-functions.sh |  2 +
 3 files changed, 93 insertions(+), 42 deletions(-)
-- 
2.18.0.345.g5c9ce644c3-goog
Next: Stefan Beller
Message 1 of 26 in “Add color test for range-diff, simplify diff.c”
  1. 0/8 Add color test for range-diff, simplify diff.cStefan Beller, Jul 28, 2018
  2. 1/8 test_decode_color: understand FAINT and ITALICStefan Beller, Jul 28, 2018
  3. 2/8 t3206: add color test for range-diff --dual-colorStefan Beller, Jul 28, 2018
  4. Eric SunshineJul 28, 2018
  5. Stefan BellerJul 30, 2018
  6. 3/8 diff.c: simplify caller of emit_line_0Stefan Beller, Jul 28, 2018
  7. 4/8 diff.c: reorder arguments for emit_line_ws_markupStefan Beller, Jul 28, 2018
  8. 5/8 diff.c: add set_sign to emit_line_0Stefan Beller, Jul 28, 2018
  9. Eric SunshineJul 28, 2018
  10. 6/8 diff: use emit_line_0 once per lineStefan Beller, Jul 28, 2018
  11. 7/8 diff.c: compute reverse locally in emit_line_0Stefan Beller, Jul 28, 2018
  12. 8/8 diff.c: rewrite emit_line_0 more understandablyStefan Beller, Jul 28, 2018
  13. Eric SunshineJul 28, 2018
  14. 0/8 Add color test for range-diff, simplify diff.cStefan Beller, Jul 31, 2018
  15. 1/8 test_decode_color: understand FAINT and ITALICStefan Beller, Jul 31, 2018
  16. 2/8 t3206: add color test for range-diff --dual-colorStefan Beller, Jul 31, 2018
  17. Junio C HamanoJul 31, 2018
  18. 3/8 diff.c: simplify caller of emit_line_0Stefan Beller, Jul 31, 2018
  19. 4/8 diff.c: reorder arguments for emit_line_ws_markupStefan Beller, Jul 31, 2018
  20. 5/8 diff.c: add set_sign to emit_line_0Stefan Beller, Jul 31, 2018
  21. 6/8 diff: use emit_line_0 once per lineStefan Beller, Jul 31, 2018
  22. 7/8 diff.c: compute reverse locally in emit_line_0Stefan Beller, Jul 31, 2018
  23. 8/8 diff.c: rewrite emit_line_0 more understandablyStefan Beller, Jul 31, 2018
  24. Junio C HamanoAug 1, 2018
  25. Stefan BellerAug 1, 2018
  26. Junio C HamanoAug 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.