git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: clarify --creation-factor=<factor>

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 30, 2022, 00:25 UTC
Message-ID
<CAPig+cQ94oC-6wftkP_=RSEsOVPKeuBWuMshDkwV+Xu_FjrKeg@mail.gmail.com>
In-Reply-To
<CAPig+cTxM2vr11XRU-zrNAJRwveP0W9d0x8Euvr6HKmQicKgPQ@mail.gmail.com>
On Thu, Jul 28, 2022 at 5:09 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 11 quoted lines
> On Thu, Jul 28, 2022 at 4:59 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >> -               [--range-diff=<previous> [--creation-factor=<percent>]]
> > >> +               [--range-diff=<previous> [--creation-factor=<factor>]]
> >
> > Eric, I am not sure if the other patch for the range-diff command as
> > a standalone patch is worth it.  Perhaps you can help me by
> > submitting a single combined patch to cover the above as well as
> > what we wrote in the two patches, with you marked as the primary
> > author and with Helped-by: that credits Ævar?
>
> Will do.

Given Dscho's response in [1] which states that "percent" is more accurate than "factor", perhaps these two patches are unwanted after all, and instead the documentation of "creation factor" in Documentation/git-range-diff.txt ought to be expanded with a better explanation, as hinted in [2].

[1]: https://lore.kernel.org/git/85snn12q-po05-osqs-n1o0-n6040392q01q@tzk.qr/ [2]: https://lore.kernel.org/git/xmqq5yjf4l60.fsf@gitster.g/

Previous: Eric SunshineNext: Junio C Hamano
Message 12 of 17 in “--creation-factor=100 does not show code”
  1. Eugen KonkovJul 26, 2022
  2. Johannes SchindelinJul 28, 2022
  3. Re* --creation-factor=100 does not show codeJunio C Hamano, Jul 28, 2022
  4. Ævar Arnfjörð BjarmasonJul 28, 2022
  5. Junio C HamanoJul 28, 2022
  6. Ævar Arnfjörð BjarmasonJul 28, 2022
  7. Junio C HamanoJul 28, 2022
  8. format-patch: clarify --creation-factor=<factor>Eric Sunshine, Jul 28, 2022
  9. Ævar Arnfjörð BjarmasonJul 28, 2022
  10. Junio C HamanoJul 28, 2022
  11. Eric SunshineJul 28, 2022
  12. Eric SunshineJul 30, 2022
  13. Junio C HamanoJul 31, 2022
  14. Johannes SchindelinJul 29, 2022
  15. Junio C HamanoJul 29, 2022
  16. Junio C HamanoAug 1, 2022
  17. Eugen KonkovApr 2, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.