Re: Re* --creation-factor=100 does not show code

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 28, 2022, 19:46 UTC
Message-ID: <220728.86fsilj9w1.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqqwnbxb092.fsf@gitster.g>

On Thu, Jul 28 2022, Junio C Hamano wrote:

Show 17 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> That algorithm section also says:
>>
>> 	The cost of an edge o--C is the size of C's diff, modified by a
>> 	fudge factor that should be smaller than 100%.
>>
>> Which I find quite confusing to follow, isn't that "fudge factor" the
>> <percent> (or <factor>) we're accepting with --creation-factor? Doesn't
>> that also need to be adjusted?
>>
>> I still find this documentation quicke lacking, if the default is 60 and
>> it's not 0..100 what is it then? Are values of 200 sensible in some
>> cases, 1k? 10k?
>
> I think 90% of your responses are better answered not by me.  Feel
> free to edit "to:" header field when that happens next time ;-)

It's a comment on your patch: If you're updating the <percent> early in the doc, shouldn't the proposed update also update the wording later on to refer to "factor?"