Re: [PATCH 1/1] add hook pre-p4-submit

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 26, 2018, 09:21 UTC
Message-ID: <CAPig+cQ80DrYJjYgJEvfcpeNEscgNBvj7ydwxMMVRf6kBfpaqQ@mail.gmail.com>
In-Reply-To: <CAAE-R+_BWJAB3zsZUZ+=Zn6SiSkzrWG0EYwBF_OcX_V+2idCww@mail.gmail.com>

On Wed, Jul 25, 2018 at 10:08 PM chen bin <chenbin.sh@gmail.com> wrote:

Show 5 quoted lines

> The hook does not receive any information or input from git. The
> original requirement
> comes from my colleague. He want to run unit test automatically before
> submitting code
> to remote repository. Or else CI server will send the blame mail to the manager.

Okay, that seems in line with a hook such as pre-commit. Please do update the documentation to mention that the hook takes no arguments and nothing on standard input, and perhaps describe in the documentation an example use-case (as you did here).

I'm not a p4 or git-p4 user, but, out of curiosity, would there be any information which could be supplied to the hook as arguments or standard input (or both) which would help the hook author implement the hook more easily? Perhaps such information would be fodder for a future enhancement (not necessarily needed for this patch).

> The hook actually stops the submit process from start instead of abort
> submit in midway.
> So nothing is touched when hook exits with status 1.

This might be a good thing to add to the documentation, as well.

Show 9 quoted lines

> I'm not sure whether `git-p4` should print some "hook rejection" message.
> Current implementation is same as other hooks (`pre-commit`, for example).
> Only hook itself is responsible to print error messages.
>
> Personally I don't have opinion whether we should print out hook
> related message inside
> `git-p4.py`. I just try to following existing convention of git.
>
> What you guys think?

Following existing practice makes sense. It can always be revisited later if needed.

Thanks.