git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Add the `p4-pre-submit` hook

From
Luke Diamand <luke@diamand.org>
Date
Jul 31, 2018, 13:40 UTC
Message-ID
<CAE5ih7_jh55mLVBhiu12gmc0j3mGkm4s0VU2Stx5iGf1tK6yzA@mail.gmail.com>
In-Reply-To
<20180731084638.18793-1-szeder.dev@gmail.com>
I think there is an error in the test harness.
On 31 July 2018 at 10:46, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>> +             test_must_fail git-p4 submit --dry-run >errs 2>&1 &&>
>> +             ! grep "Would apply" err
It writes to the file "errs" but then looks for the message in "err".
Luke
Previous: SZEDER GáborNext: Junio C Hamano
Message 21 of 27 in “add hook pre-p4-submit”
  1. 1/1 add hook pre-p4-submitChen Bin, Jul 23, 2018
  2. Luke DiamandJul 25, 2018
  3. Ævar Arnfjörð BjarmasonJul 25, 2018
  4. chen binJul 25, 2018
  5. 1/1 add hook pre-p4-submitChen Bin, Jul 25, 2018
  6. Eric SunshineJul 25, 2018
  7. Junio C HamanoJul 25, 2018
  8. chen binJul 26, 2018
  9. Eric SunshineJul 26, 2018
  10. Luke DiamandJul 26, 2018
  11. chen binJul 27, 2018
  12. 1/1 add hook pre-p4-submitChen Bin, Jul 26, 2018
  13. Junio C HamanoJul 26, 2018
  14. Eric SunshineJul 26, 2018
  15. 1/1 Add the `p4-pre-submit` hookChen Bin, Jul 27, 2018
  16. Eric SunshineJul 27, 2018
  17. Junio C HamanoJul 30, 2018
  18. Luke DiamandJul 30, 2018
  19. Junio C HamanoJul 30, 2018
  20. SZEDER GáborJul 31, 2018
  21. Luke DiamandJul 31, 2018
  22. Junio C HamanoJul 31, 2018
  23. Luke DiamandJul 31, 2018
  24. chen binAug 1, 2018
  25. Junio C HamanoAug 1, 2018
  26. 1/1 Add the `p4-pre-submit` hookChen Bin, Aug 1, 2018
  27. Junio C HamanoAug 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.