Re: [GSoC][PATCH] remote: relocate valid_remote_name

From: Meet Soni <meetsoni3017@gmail.com>
Date: Feb 6, 2025, 10:14 UTC
Message-ID: <CAPhwyn1_tMtZzMeNY3LhHxaVyLaD=nhWk8d-YNPHFq5ouJU7Hw@mail.gmail.com>
In-Reply-To: <Z6IoZ1_1wGiOo4Bi@pks.im>

On Tue, 4 Feb 2025 at 20:17, Patrick Steinhardt <ps@pks.im> wrote:

Show 12 quoted lines

>
> On Tue, Feb 04, 2025 at 07:36:24PM +0530, Meet Soni wrote:
> > On Tue, 4 Feb 2025 at 13:25, Patrick Steinhardt <ps@pks.im> wrote:
> > > The change itself looks straight-forward to me. Did you happen to check
> > > whether this allows you to drop any includes for "refspec.h"?
> >
> > I think you mean refspec.c, as refspec.h doesn’t have includes.
> > Yeah, I did check -- no include drop found in refspec.c.
>
> Not quite -- I meant whether any other file that previously included
> "refspec.h" now doesn't have to anymore because the function declaration
> was moved.

Oh, I misunderstood. I checked again, but I didn't find any includes that could be dropped.

Meet