Re: [GSoC][PATCH] remote: relocate valid_remote_name

From

Meet Soni <meetsoni3017@gmail.com>

Date

Feb 4, 2025, 14:06 UTC

Message-ID

<CAPhwyn094ySxG8=p3_jF+Z+0g6h4hL5ELBYhOLv+Th8zX04Urg@mail.gmail.com>

In-Reply-To

<Z6HH8mWDpJUSHDd7@pks.im>

On Tue, 4 Feb 2025 at 13:25, Patrick Steinhardt <ps@pks.im> wrote:

> Nit: you don't only move the function declaration from "refspec.h" to
> "remote.h", but also move its definition from "refspec.c" to "remote.c".
> So you might want to instead say that you move the function between
> subsystems, which would imply both moves.
>

Makes sense. Thanks for pointing it out.

> The change itself looks straight-forward to me. Did you happen to check
> whether this allows you to drop any includes for "refspec.h"?
>