Re: [PATCH] unblock and unignore SIGPIPE

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 18, 2014, 15:04 UTC
Message-ID: <CAPc5daWHUvV1tyUsz0kN0i53cSF43YeNVsC9hGdudpq60Pfzyg@mail.gmail.com>
In-Reply-To: <CAJrMUs-68cNXdh1dbRbjGBdrT0hukR7DH=mf7v05EDjL7qzP-Q@mail.gmail.com>

Thanks; just to save time, you may want to look at what has already been queued on 'pu'.

On Thu, Sep 18, 2014 at 7:35 AM, Patrick Reynolds <piki@github.com> wrote:

Show 18 quoted lines

> On Wed, Sep 17, 2014 at 3:11 AM, Jeff King <peff@peff.net> wrote:
>> Would we want to call it from external C commands, too? For the most
>> part, git.c is the entry point for running git commands, and any
>> sanitizing it does will be inherited by sub-commands. But it _is_ still
>> legal to call dashed commands individually, and even required in some
>> cases (e.g., git-upload-pack for ssh clients).
>
> git-upload-pack is protected pretty well from SIGPIPE shenanigans,
> because its stdout all goes through write_or_die, as of cdf4fb8.  We
> did, long ago, have some EPIPE problems with upload-pack and SSH
> clients, but it all predates cdf4fb8.
>
> So I think it's redundant to unblock SIGPIPE in git-upload-pack.
>
> I'll tidy up as Junio recommended, recheck the tests, and submit
> an updated patch shortly.
>
> --Patrick