git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] unblock and unignore SIGPIPE

From
PRPatrick Reynolds <piki@github.com>
Date
Sep 18, 2014, 14:35 UTC
Message-ID
<CAJrMUs-68cNXdh1dbRbjGBdrT0hukR7DH=mf7v05EDjL7qzP-Q@mail.gmail.com>
In-Reply-To
<20140917081148.GB16200@peff.net>
On Wed, Sep 17, 2014 at 3:11 AM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> Would we want to call it from external C commands, too? For the most
> part, git.c is the entry point for running git commands, and any
> sanitizing it does will be inherited by sub-commands. But it _is_ still
> legal to call dashed commands individually, and even required in some
> cases (e.g., git-upload-pack for ssh clients).

git-upload-pack is protected pretty well from SIGPIPE shenanigans, because its stdout all goes through write_or_die, as of cdf4fb8. We did, long ago, have some EPIPE problems with upload-pack and SSH clients, but it all predates cdf4fb8.

So I think it's redundant to unblock SIGPIPE in git-upload-pack.

I'll tidy up as Junio recommended, recheck the tests, and submit an updated patch shortly.

--Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “unblock and unignore SIGPIPE”
  1. unblock and unignore SIGPIPEPatrick Reynolds, Aug 15, 2014
  2. Eric WongAug 18, 2014
  3. Patrick ReynoldsAug 22, 2014
  4. Junio C HamanoSep 16, 2014
  5. Jeff KingSep 17, 2014
  6. Junio C HamanoSep 17, 2014
  7. Patrick ReynoldsSep 18, 2014
  8. Junio C HamanoSep 18, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.