Re: [PATCH v6 28/32] gc: style change -- no SP before closing bracket

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2014, 04:40 UTC
Message-ID: <CAPc5daVnE4P4f9vC0r=jrzxU9exs1f1R8hVJyzqTNrpzW5MVGg@mail.gmail.com>
In-Reply-To: <CAPig+cSfbs3NuyfbrUrJ5BGP9J7GvGCSda2E7ZjA2k4ZXotNRQ@mail.gmail.com>

On Wed, Jul 9, 2014 at 2:47 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 7 quoted lines

> On Wed, Jul 9, 2014 at 3:33 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>
> Yet, there is a space after the opening '{'. So, this is now
> inconsistently formatted as:
>
>     { foo, bar}
>

So, if we drop the other hunk and keep only the one below, the patch needs to be retitled with s/bracket/parenthesis/...

Show 11 quoted lines

>> @@ -298,7 +298,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>>         argv_array_pushl(&pack_refs_cmd, "pack-refs", "--all", "--prune", NULL);
>>         argv_array_pushl(&reflog, "reflog", "expire", "--all", NULL);
>>         argv_array_pushl(&repack, "repack", "-d", "-l", NULL);
>> -       argv_array_pushl(&prune, "prune", "--expire", NULL );
>> +       argv_array_pushl(&prune, "prune", "--expire", NULL);
>>         argv_array_pushl(&rerere, "rerere", "gc", NULL);
>>
>>         git_config(gc_config, NULL);
>> --
>> 1.9.1.346.ga2b5940