Re: [PATCH v1 2/2] entry.c: check if file exists after checkout

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 6, 2017, 07:58 UTC
Message-ID: <CAPc5daU4K3=-qhOiMx73oyCX7tGCv87L4uB9pu3M2C90s2sLMg@mail.gmail.com>
In-Reply-To: <20171006060542.llx4golnkuxksy7z@sigill.intra.peff.net>

On Fri, Oct 6, 2017 at 3:05 PM, Jeff King <peff@peff.net> wrote:

Show 10 quoted lines

>
>> Because we cannot quite tell between the two cases (one is error--we
>> wrote or we thought we wrote, but we cannot find it, the other is
>> dubious--somebody was racing with us in the filesystem), I think it
>> is reasonable to err on the safer side, even though an error abort
>> while doing "as we know we wrote the thing that match the index, we
>> might as well lstat and mark the cache entry as up-to-date" might be
>> a bit irritating.
>
> OK. I can live with that line of thought.

Still that, or any other, line of thought we follow to declare that it is a good change should be recorded in the log ;-)