Re: [PATCH 1/3] write_entry: fix leak when retrying delayed filter
- From
Simon Ruderich <simon@ruderich.org>
- Date
- Oct 10, 2017, 09:23 UTC
- Message-ID
- <20171010092319.ugim7ww7t6ks2vqf@ruderich.org>
- In-Reply-To
- <xmqq7ew3swhi.fsf@gitster.mtv.corp.google.com>
On Tue, Oct 10, 2017 at 09:00:09AM +0900, Junio C Hamano wrote:
Show 10 quoted lines
>> --- a/entry.c
>> +++ b/entry.c
>> @@ -283,6 +283,7 @@ static int write_entry(struct cache_entry *ce,
>> if (dco && dco->state != CE_NO_DELAY) {
>> /* Do not send the blob in case of a retry. */
>> if (dco->state == CE_RETRY) {
>> + free(new);
>> new = NULL;
>> size = 0;
>> }FREE_AND_NULL(new)?
Regards Simon
-- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9