Re: [PATCH v3] t7063: work around FreeBSD's lazy mtime update feature

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2016, 17:52 UTC
Message-ID: <CAPc5daU49iVYw14sYeshXDbHGE_nW4vWyM=2XSz-buACVLFwoA@mail.gmail.com>
In-Reply-To: <20160803174522.5571-1-pclouds@gmail.com>

On Wed, Aug 3, 2016 at 10:45 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 11 quoted lines

>  v3 differs from v2 in one line
>
>     --- a/t/t7063-status-untracked-cache.sh
>     +++ b/t/t7063-status-untracked-cache.sh
>     @@ -11,7 +11,7 @@ test_description='test untracked cache'
>      # containing directory in sync with the reality after doing blah and
>      # before checking the fast path behaviour
>      sync_mtime () {
>     -   find . -type d -exec ls -ld {} \; >/dev/null
>     +   find . -type d -ls >/dev/null
>      }

"this and that" and "blah" are still there.

If you mean to tell the user "I won't describe it in detail, if you really want to know, go run blame yourself", spell it out like so. I was hoping that you can summarize in-line there to help the readers here.

Show 26 quoted lines

> +# On some filesystems (e.g. FreeBSD's ext2 and ufs) this and that
> +# happens when we do blah, which forces the untracked cache code to
> +# take the slow path.  A test that wants to make sure the fast path
> +# works correctly should call this helper to make mtime of the
> +# containing directory in sync with the reality after doing blah and
> +# before checking the fast path behaviour
> +sync_mtime () {
> +       find . -type d -ls >/dev/null
> +}
> +
>  avoid_racy() {
>         sleep 1
>  }
> @@ -416,7 +426,8 @@ test_expect_success 'create/modify files, some of which are gitignored' '
>         echo four >done/four && # four is gitignored at a higher level
>         echo five >done/five && # five is not gitignored
>         echo test >base && #we need to ensure that the root dir is touched
> -       rm base
> +       rm base &&
> +       sync_mtime
>  '
>
>  test_expect_success 'test sparse status with untracked cache' '
> --
> 2.9.1.566.gbd532d4
>