Re: [PATCH v2] t7063: work around FreeBSD's lazy mtime update feature

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 3, 2016, 16:25 UTC
Message-ID: <CACsJy8C3xuCj-2=8B18qpDhbRtW=S2UQ1zFLTaeqRqgXYSeyBw@mail.gmail.com>
In-Reply-To: <xmqqmvktakvt.fsf@gitster.mtv.corp.google.com>

On Wed, Aug 3, 2016 at 6:16 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>>  v2 goes with Junio's suggestion (good one!).
>
> Ehh, have you even read what you copied and pasted?  "this and that"
> and "blah" are meant to be placeholders for you to fill in.

I did. But after a bit of consideration, I think the confusion caused by "this and that" would force the reader to blame and read the entire commit message.

> I am not sure if "-exec ls -ld" is a good idea.  Doesn't "find" by
> itself does enough lstat(2) call to work already?

Hmm.. because in some cases we could have dtype from readdir()?

> Even if it were
> necessary to trigger a separate stat(2) call, wouldn't "-ls" be
> sufficient?

Yep. Let me run some tests before sending v3.

-- 
Duy