Re: [PATCH 2/3] Makefile: avoid multiple -Wall in CFLAGS

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 28, 2021, 11:03 UTC
Message-ID: <CAPUEspj_hOXRc2d+c+DTvShgWX8NH+fXKD4Pk+_G=nj9Z97VnQ@mail.gmail.com>
In-Reply-To: <87wnn1vxh8.fsf@evledraar.gmail.com>

On Tue, Sep 28, 2021 at 2:52 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

>
> This really breaks things for anyone who's relying on specifing CFLAGS
> now to clobber the default -Wall configuration, e.g. on both xlc and aCC
> after this:

got it; then it should have been DEVELOPER_CFLAGS+=-Wall the one to keep, and that way there is no need to hack CFLAGS just to disable -Wall in non GNU compilers IMHO of course, that still leaves the question if -Wall is still something we want to have by default for people NOT using DEVELOPER=1 to compile.

> I'd end up with -Wall twice, gcc doesn't complain, but maybe some other
> toolchains do.

clang wouldn't complain either, and indeed you already have 2 -Wall, which is what I was trying to clean up.

> But I think this needs to at least have
> s/DEVELOPER_CFLAGS/WARNING_CFLAGS/g or something.

makes sense, even though I assumed there would be less churn if reusing the variable you came up with. in any case, I think it is clear that this change that I thought will be tiny might be better tackled in a different thread, not to complicate the main reason for this thread, which was to make sure that users that might build the next release (even with DEVELOPER=1) are less likely to find issues than the developers that got their first taste of "pedantic" in master.

will wait for more feedback before doing a reroll, but would be nice to get feedback also in the other 2 patches, which hopefully are less problematic.

Carlo