git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] config.mak.dev: simplify compiler check for multiple compilers

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Sep 28, 2021, 09:10 UTC
Message-ID
<20210928091054.78895-4-carenas@gmail.com>
In-Reply-To
<20210928091054.78895-1-carenas@gmail.com>

1da1580e4c (Makefile: detect compiler and enable more warnings in DEVELOPER=1, 2018-04-14), includes an $(or) of two different filters to check for both gcc and clang versions.

As shown in a previous patch, a simpler syntax is available so apply the same logic here also for consistency.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 config.mak.dev | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.mak.dev b/config.mak.dev
index 90c47d2782..b66fae8665 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -31,7 +31,7 @@ ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
 DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
 endif
 
-ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
+ifneq ($(filter clang4 gcc6,$(COMPILER_FEATURES)),)
 DEVELOPER_CFLAGS += -Wextra
 # if a function is public, there should be a prototype and the right
 # header file should be included. If not, it should be static.
-- 
2.33.0.955.gee03ddbf0e
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 11 of 13 in “Makefile: tighten pedantic flag”
  1. 0/3 Makefile: tighten pedantic flagCarlo Marcelo Arenas Belón, Sep 28, 2021
  2. 1/3 Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format betterCarlo Marcelo Arenas Belón, Sep 28, 2021
  3. Ævar Arnfjörð BjarmasonSep 28, 2021
  4. Junio C HamanoSep 28, 2021
  5. 2/3 Makefile: avoid multiple -Wall in CFLAGSCarlo Marcelo Arenas Belón, Sep 28, 2021
  6. Ævar Arnfjörð BjarmasonSep 28, 2021
  7. Carlo ArenasSep 28, 2021
  8. Junio C HamanoSep 28, 2021
  9. Carlo ArenasSep 28, 2021
  10. Junio C HamanoSep 29, 2021
  11. 3/3 config.mak.dev: simplify compiler check for multiple compilersCarlo Marcelo Arenas Belón, Sep 28, 2021
  12. Ævar Arnfjörð BjarmasonSep 28, 2021
  13. Junio C HamanoSep 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.