Re: preparing for 2.34.1
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Nov 22, 2021, 20:51 UTC
- Message-ID
- <CAPUEsphNH9pfQoHqVgJfkQCU-Li45dz4QtGtDjWu5bDV9A3PEg@mail.gmail.com>
- In-Reply-To
- <xmqqr1b8gkhg.fsf@gitster.g>
On Mon, Nov 22, 2021 at 11:54 AM Junio C Hamano <gitster@pobox.com> wrote:
> > There are a few topics [*] to fix regressions introduced in the > previous cycle
There was another regression report[1] that I just fished out of my spam folder and that I introduced in 3d411afabc (editor: save and reset terminal after calling EDITOR, 2021-10-05), but that I have not yet produced a fix for or fully understood.
The gist is that some people seem to be using a hack[2] dscho posted a few years ago to get info from git programmatically and I just didn't expect someone would try to invoke the EDITOR unless they had a terminal, so the fix might be to just add an isatty(0) call, but reverting that commit would be also an option.
Carlo
[1] https://lore.kernel.org/git/ee302c98-da27-da43-e684-c7ec8b225360@gmx.net/ [2] https://yhbt.net/lore/all/nycvar.QRO.7.76.6.1903221436590.41@tvgsbejvaqbjf.bet/T/