Re: preparing for 2.34.1
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Nov 22, 2021, 22:50 UTC
- Message-ID
- <CAPUEsph+F5inaga266xdFoc6KibjFo7hYh0ycdAkM9Q8yk5Ryg@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2111222319100.63@tvgsbejvaqbjf.bet>
On Mon, Nov 22, 2021 at 2:28 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> I was tempted to suggest an `isatty(2)`, but that probably comes with its > own problems, too.
I went with isatty(1) in the suggested minimal bugfix[1] since I think it is safe to assume that no one that doesn't have stdout connected to a terminal should even care if the invoking editor dies and messes with their terminal, and hopefully whoever is hacking git commands that invoke an editor to read its output, is actually not doing it through a tty but a pipe.
What problems do you foresee with isatty?, the current code already checks for errors on accessing the console, but as Phillip suggested[2] in that thread a signal might be generated for some of those errors when the terminal is shared with other processes.
Carlo
CC: +Phillip
[1] https://lore.kernel.org/git/20211122222850.674-1-carenas@gmail.com/ [2] https://lore.kernel.org/git/04ab7301-ea34-476c-eae4-4044fef74b91@gmail.com/T/#u