git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib: fix non-portable pattern bracket expressions

From
Carlo Arenas <carenas@gmail.com>
Date
Feb 12, 2019, 10:47 UTC
Message-ID
<CAPUEspg+j+9mm_UX=rNAn-3dmXWNq_Wh3zHjE-PkGfo34405jg@mail.gmail.com>
In-Reply-To
<20190212003446.GF13301@sigill.intra.peff.net>
On Mon, Feb 11, 2019 at 4:35 PM Jeff King <peff@peff.net> wrote:
>
> Ah, doubly puzzling. It works fine in my Debian dash (but fnmatch was
> enabled in 0.5.8-1 there, too).

FWIW, it is reported by both checkbashisms and shellcheck if "linting" could be considered of help to track these kind of issues.

other "portability" issues seem safe, mainly because they are either silly (like the use of local) or meant to be used only with bash (as on the mingw specific functions or the bash version check that was broken recently for NetBSD) but the functions run_with_limited_{cmdline,stack} that use `ulimit -s` might be worth looking into

Carlo
Previous: Jeff King
Message 13 of 13 in “test-lib: make '--stress' more bisect-friendly”
  1. test-lib: make '--stress' more bisect-friendlySZEDER Gábor, Feb 8, 2019
  2. Jeff KingFeb 8, 2019
  3. Jeff KingFeb 8, 2019
  4. SZEDER GáborFeb 8, 2019
  5. Jeff KingFeb 8, 2019
  6. SZEDER GáborFeb 8, 2019
  7. Jeff KingFeb 8, 2019
  8. test-lib: fix non-portable pattern bracket expressionsSZEDER Gábor, Feb 11, 2019
  9. Junio C HamanoFeb 11, 2019
  10. Jeff KingFeb 11, 2019
  11. SZEDER GáborFeb 12, 2019
  12. Jeff KingFeb 12, 2019
  13. Carlo ArenasFeb 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.