Re: [PATCH] test-lib: make '--stress' more bisect-friendly

From: Jeff King <peff@peff.net>
Date: Feb 8, 2019, 19:12 UTC
Message-ID: <20190208191257.GE27673@sigill.intra.peff.net>
In-Reply-To: <20190208183307.GZ10587@szeder.dev>

On Fri, Feb 08, 2019 at 07:33:07PM +0100, SZEDER Gábor wrote:

Show 12 quoted lines

> On Fri, Feb 08, 2019 at 11:49:37AM -0500, Jeff King wrote:
> >   One other thing I've noticed with it: I forget to add my custom
> >   --root=/var/ram/git-tests when I invoke it, so my hard disk goes
> >   crazy (and the tests often run slower!). I'm not sure if there's a
> >   convenient fix.
> 
> OTOH, that could introduce more variance in the timing of the test's
> commands, thus potentially increasing the chances of a failure.  I
> dunno.
> 
> Maybe ./t1234-foo.sh should learn to respect DEFAULT_TEST_OPTS
> somehow?

Yeah, that was what I was thinking. On the other hand, I'd actually find that a little bit annoying for the non-stress case. I commonly do "./t1234-foo.sh" in order to dig into a specific breakage, and having the failing trash directory right there is convenient (and I don't care as much about speed, since I'm just running it once).

I may just gut my "stress" script and make it a wrapper for calling the script with "--stress --root=...". :)

-Peff