git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t0200: use path checking helpers

From
Usman Akinyemi <usmanakinyemi202@gmail.com>
Date
Oct 14, 2026, 14:45 UTC
Message-ID
<CAPSxiM-VB_JUexggYTMmYcHe7W7pw=XNuMrENB4gZoq2Zo8J7Q@mail.gmail.com>
In-Reply-To
<20261014105613.49334-1-vua.okafor@gmail.com>
>
> Replace direct directory and file checks with the corresponding
> test helpers in t/t0200-gettext-basic.sh.

This is a little bit more confusing. The commit message does not really show why you did what you did. Along the line of

"Modernize the code testing whether a file exists in "filename"' seems better. Also, your patches is doing two things, i.e modernizing the 'test -f' and 'test -d'. Ideally a patch should only focus on one thing but, since this is simple patch. It is okay.

>
> Instances were located using:
> git grep -n -E 'test -[efds]' -- 't/t[0-9]*.sh'
This part is nto necessary.
Show 16 quoted lines
>
> Signed-off-by: Victor Okafor <vua.okafor@gmail.com>
> ---
>  t/t0200-gettext-basic.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
>  test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
> -    test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
> +    test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
>  '
>
>  # TODO: When we have more locales, generalize this to test them
> --
> 2.55.0
>
Thanks
>
Previous: Victor OkaforNext: Junio C Hamano
Message 2 of 3 in “t0200: use path checking helpers”
  1. t0200: use path checking helpersVictor Okafor, Oct 14, 2026
  2. Usman AkinyemiOct 14, 2026
  3. Junio C HamanoOct 14, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.