threads / patch / 66533

patcht0200: use path checking helpers

Subject: [PATCH] t0200: use path checking helpers

## tl;dr

3 messages between Oct 14, 2026 and Oct 14, 2026. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Victor Okafor· Oct 14, 2026, 10:56 UTC · lore

Replace direct directory and file checks with the corresponding test helpers in t/t0200-gettext-basic.sh.

Instances were located using: git grep -n -E 'test -[efds]' -- 't/t[0-9]*.sh'

Signed-off-by: Victor Okafor <vua.okafor@gmail.com>
---
 t/t0200-gettext-basic.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to t/t0200-gettext-basic.sh +2 −2
diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
index 8db26c1ada..177cf658fd 100755
--- a/t/t0200-gettext-basic.sh
+++ b/t/t0200-gettext-basic.sh
@@ -31,12 +31,12 @@ test_expect_success 'xgettext sanity: Comment extraction with --add-comments sto
 '
 
 test_expect_success GETTEXT 'sanity: $TEXTDOMAINDIR exists without NO_GETTEXT=YesPlease' '
-    test -d "$TEXTDOMAINDIR" &&
+    test_path_is_dir "$TEXTDOMAINDIR" &&
     test "$TEXTDOMAINDIR" = "$GIT_TEXTDOMAINDIR"
 '
 
 test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
-    test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
+    test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
 '
 
 # TODO: When we have more locales, generalize this to test them
-- 
2.55.0
Usman Akinyemi· Oct 14, 2026, 14:45 UTC · re: Victor Okafor · lore

Re: [PATCH] t0200: use path checking helpers

>
> Replace direct directory and file checks with the corresponding
> test helpers in t/t0200-gettext-basic.sh.

This is a little bit more confusing. The commit message does not really show why you did what you did. Along the line of

"Modernize the code testing whether a file exists in "filename"' seems better. Also, your patches is doing two things, i.e modernizing the 'test -f' and 'test -d'. Ideally a patch should only focus on one thing but, since this is simple patch. It is okay.

>
> Instances were located using:
> git grep -n -E 'test -[efds]' -- 't/t[0-9]*.sh'
This part is nto necessary.
Show 16 quoted lines
>
> Signed-off-by: Victor Okafor <vua.okafor@gmail.com>
> ---
>  t/t0200-gettext-basic.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
>  test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
> -    test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
> +    test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
>  '
>
>  # TODO: When we have more locales, generalize this to test them
> --
> 2.55.0
>
Thanks
>
Junio C Hamano· Oct 14, 2026, 19:24 UTC · re: Usman Akinyemi · lore

Re: [PATCH] t0200: use path checking helpers

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
Show 15 quoted lines
>>
>> Replace direct directory and file checks with the corresponding
>> test helpers in t/t0200-gettext-basic.sh.
> This is a little bit more confusing. The commit message does not
> really show why you did what you did. Along the line of
>
> "Modernize the code testing whether a file exists in "filename"' seems
> better. Also, your patches is doing two things, i.e modernizing the 'test -f'
> and 'test -d'. Ideally a patch should only focus on one thing but,
> since this is
> simple patch. It is okay.
>>
>> Instances were located using:
>> git grep -n -E 'test -[efds]' -- 't/t[0-9]*.sh'
> This part is nto necessary.

Since many candidates are working on similar microprojects (which is fine) and making the same mistakes (which is expected), perhaps mentors should tell them to read the review exchanges on other candidates' patches and learn from them.

Show 18 quoted lines
>>
>> Signed-off-by: Victor Okafor <vua.okafor@gmail.com>
>> ---
>>  t/t0200-gettext-basic.sh | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/t/t0200-gettext-basic.sh b/t/t0200-gettext-basic.sh
>>  test_expect_success GETTEXT 'sanity: Icelandic locale was compiled' '
>> -    test -f "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
>> +    test_path_is_file "$TEXTDOMAINDIR/is/LC_MESSAGES/git.mo"
>>  '
>>
>>  # TODO: When we have more locales, generalize this to test them
>> --
>> 2.55.0
>>
> Thanks
>>

← back to recent threads