Re: [PATCH v2 3/6] commit: add a reword suboption to --fixup

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Feb 26, 2021, 10:35 UTC
Message-ID: <CAPSFM5d3M5joEBmAkY_-7hYGyz_e7HVpWmR6EN2U2Hw7V_LEqQ@mail.gmail.com>
In-Reply-To: <xmqq7dmvubus.fsf@gitster.g>

Hi Junio,

On Fri, 26 Feb 2021 at 02:03, Junio C Hamano <gitster@pobox.com> wrote:

[...]

Show 9 quoted lines

> > +     if (argc)
> > +             die(_("cannot combine reword option of --fixup with paths"));
>
> It would be easier if the user is told "foo" in the message when
>
>     $ git commit --fixup=reword:HEAD~ -- foo
>
> (from your tests) is attempted, no?
>

Okay, will print the passed argument in the message.

Show 9 quoted lines

>
> I am not sure this comment is all that helpful to the translaters.
> If they are not allowed to translate <amend|reword> part, telling
> them what that part means does not help them very much.
>
>         Leave "[(amend|reword):]" as-is, and only translate <commit>.
>
> would be more direct without distracting them with useless piece of
> information, no?

Yes, I agree and will correct it.