Re: [PATCH 4/6] t7500: add tests for --fixup[amend|reword] options

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Feb 18, 2021, 10:15 UTC
Message-ID: <CAPSFM5cjJ_b510wx+RtVkyxHk-aFDpOHaFRWqQuMuDf=73nBiA@mail.gmail.com>
In-Reply-To: <xmqqsg5ujwi2.fsf@gitster.g>

On Thu, 18 Feb 2021 at 01:29, Junio C Hamano <gitster@pobox.com> wrote:

[...]

Show 8 quoted lines

> > +for opt in --all --include --only
> > +do
> > +     test_fixup_reword_opt $opt
> > +done
>
> As I suspected earlier, a pathspec is not tested here, but it should
> be.
>

Okay, I will add it here.

Show 8 quoted lines

> > +test_expect_success '--fixup=reword: -F give error message' '
> > +     echo "fatal: Only one of -c/-C/-F/--fixup can be used." >expect &&
> > +     test_must_fail git commit --fixup=reword:HEAD~ -F msg  2>actual &&
> > +     test_cmp expect actual
> > +'
>
> Why?  If you can use -m msg, you should be able to use -F msgfile,
> too, no?

Earlier I was thinking to let the `--fixup=amend:` use the same options as of current `--fixup=` . But yes I agree that there should be -F option also with `amend` and `reword`.

Thanks for the corrections, will do all the changes and update in the next revision.

Thanks and Regards, Charvi