Re: [PATCH 3/5] roaring: teach Git to write roaring bitmaps
- From
Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
- Date
- Oct 30, 2022, 06:35 UTC
- Message-ID
- <CAPOJW5z_ZRChNo8PGBmJu=vvjTL2cYL8oTdVwoDRh-UHt2Dy4w@mail.gmail.com>
- In-Reply-To
- <CAPOJW5yxRETdVk014gQYFud9_Nrt+OQGSVNQ8Pw2wDEMMFMm1Q@mail.gmail.com>
Hello all,
It has been a month since I didn't get involved in any open source contributions (including Git). This is due to the fact that I was focusing more on mastering theories and also that it was a festive month. So, I am now resuming my work. There are many things I have to cover (including this patch series). But before that I want to ask you a question - As you have noticed already, the Roaring library has a lot of styling issues (Moreover it is using C11). So Should I fix all these issues? or Should I make a new library (using Git's compatibility library "git-compat-util.h") by taking CRoaring as a reference? The pros are that it would be easier to format the bitmap library specific files and it can use Git compatible functions.
I would love to hear your opinions. Thanks :)