Re: [PATCH 0/5] [RFC] introduce Roaring bitmaps to Git

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Sep 20, 2022, 14:05 UTC
Message-ID: <CAPOJW5wkXrV8eOysz6aJ5jN2u_u-iTX_3om3tSDKw+EmfCJBEw@mail.gmail.com>
In-Reply-To: <97a8eb90-06c2-f79e-fc9b-940ae89b88af@github.com>

Hi Derrick,

On Mon, Sep 19, 2022 at 11:48 PM Derrick Stolee <derrickstolee@github.com> wrote:

Show 6 quoted lines

> I look forward to your next version. I hope to see some information about
> the performance characteristics across the two versions. Specifically:
>
> 1. How do various test in t/perf/ change between the two formats?
> 2. For certain test repos (git/git, torvalds/linux, etc.) how much does
>    the .bitmap file change in size across the formats?

Yeah, sure. I will be including the performance test result in the next version :)

Show 13 quoted lines

> >  Makefile                   |     3 +
> >  bitmap.c                   |   225 +
> >  bitmap.h                   |    33 +
> ...
> >  ewah/bitmap.c              |    61 +-
> >  ewah/ewok.h                |    37 +-
> ...
> >  roaring/roaring.c          | 20047 +++++++++++++++++++++++++++++++++++
> >  roaring/roaring.h          |  1028 ++
>
> I wonder if there is value in modifying the structure of these files
> into a bitmap/ directory and then perhaps ewah/ and roaring/ within
> each? Just a thought.

Great idea! Thanks! Will change it in the next version..

Thanks :)