git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t7063: mtime-mangling instead of delays in untracked cache testing

From
Tao Klerks <tao@klerks.biz>
Date
Mar 1, 2022, 09:44 UTC
Message-ID
<CAPMMpojHUds8dxKNQcMe6nLj_W6ANazpTH38jBzWix4oLHshPg@mail.gmail.com>
In-Reply-To
<xmqqr17my6pq.fsf@gitster.g>
On Mon, Feb 28, 2022 at 11:19 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>
> "Tao Klerks via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +chmmtime_worktree_root () {
>
> Not "chmtime_worktree_root"?  Is doubled-m intended?
>
Oops, typo, fixing.
Show 23 quoted lines
> > +     # chmtime doesnt handle relative paths on windows, so need
> > +     # to "hardcode" a reference to the worktree folder name.
> > +     cd .. &&
> > +     test-tool chmtime $1 worktree &&
> > +     cd worktree
>
> An unsuspecting caller will be left in a directory it didn't expect
> to when "test-tool chmtime" fails, which is not nice.
>
>         (
>                 cd .. &&
>                 test-tool chmtime "$1" worktree
>         )
>
> at least until the tool learns to do
>
>         test-tool chmtime "$1" ../worktree
>
> or
>
>         test-tool -C.. chmtime "$1" worktree
>
> Oh, isn't the last one already available?
Ah, lovely, thank you!
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 10 of 30 in “Reduce explicit sleep calls in t7063 untracked cache tests”
  1. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Feb 28, 2022
  2. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Feb 28, 2022
  3. Jeff HostetlerFeb 28, 2022
  4. Junio C HamanoFeb 28, 2022
  5. Tao KlerksMar 1, 2022
  6. Junio C HamanoFeb 28, 2022
  7. Tao KlerksMar 1, 2022
  8. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Feb 28, 2022
  9. Junio C HamanoFeb 28, 2022
  10. Tao KlerksMar 1, 2022
  11. Ævar Arnfjörð BjarmasonFeb 28, 2022
  12. Jeff HostetlerFeb 28, 2022
  13. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Mar 1, 2022
  14. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Mar 1, 2022
  15. Jeff HostetlerMar 1, 2022
  16. Tao KlerksMar 1, 2022
  17. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Mar 1, 2022
  18. Junio C HamanoMar 1, 2022
  19. Tao KlerksMar 1, 2022
  20. Tao KlerksMar 1, 2022
  21. Junio C HamanoMar 1, 2022
  22. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Mar 2, 2022
  23. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Mar 2, 2022
  24. Johannes SchindelinMar 9, 2022
  25. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Mar 2, 2022
  26. Johannes SchindelinMar 9, 2022
  27. Tao KlerksMar 5, 2022
  28. Junio C HamanoMar 6, 2022
  29. Tao KlerksMar 7, 2022
  30. Junio C HamanoMar 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.