git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Feb 28, 2022, 15:29 UTC
Message-ID
<06511c93-3e40-a5d4-142c-cab81199e75e@jeffhostetler.com>
In-Reply-To
<pull.1166.git.1646041236.gitgitgadget@gmail.com>
On 2/28/22 4:40 AM, Tao Klerks via GitGitGadget wrote:
Show 29 quoted lines
> As noted in a recent proposed patch to t/t7519-status-fsmonitor.sh, a number
> of test cases in t\t7063-status-untracked-cache.sh explicitly sleep a
> second, in order to avoid the untracked cache content being invalidated by
> an mtime race condition.
> 
> Even though it's only 9 seconds of sleeping that can be straightforwardly
> replaced, it seems worth fixing if possible.
> 
> Replace sleep calls with backdating of filesystem changes, but first fix the
> test-tool chmtime functionality to work for directories in Windows.
> 
> I do have a question to the list here: Do mingw.c changes need to be
> upstreamed somewhere? I don't understand the exact relationship between this
> file and the MinGW project.
> 
> Tao Klerks (2):
>    t/helper/test-chmtime: update mingw to support chmtime on directories
>    t7063: mtime-mangling instead of delays in untracked cache testing
> 
>   compat/mingw.c                    | 33 ++++++++++++++++++++++++++-----
>   t/t7063-status-untracked-cache.sh | 29 ++++++++++++++++-----------
>   2 files changed, 45 insertions(+), 17 deletions(-)
> 
> 
> base-commit: 4c53a8c20f8984adb226293a3ffd7b88c3f4ac1a
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1166%2FTaoK%2Ftaok-untracked-cache-testing-remote-waits-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1166/TaoK/taok-untracked-cache-testing-remote-waits-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1166
> 

Thanks for working on this. It would be nice to be able to drop that commit (read: hack) from my fsmonitor series.

Jeff
Previous: Ævar Arnfjörð BjarmasonNext: Tao Klerks via GitGitGadget
Message 12 of 30 in “Reduce explicit sleep calls in t7063 untracked cache tests”
  1. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Feb 28, 2022
  2. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Feb 28, 2022
  3. Jeff HostetlerFeb 28, 2022
  4. Junio C HamanoFeb 28, 2022
  5. Tao KlerksMar 1, 2022
  6. Junio C HamanoFeb 28, 2022
  7. Tao KlerksMar 1, 2022
  8. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Feb 28, 2022
  9. Junio C HamanoFeb 28, 2022
  10. Tao KlerksMar 1, 2022
  11. Ævar Arnfjörð BjarmasonFeb 28, 2022
  12. Jeff HostetlerFeb 28, 2022
  13. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Mar 1, 2022
  14. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Mar 1, 2022
  15. Jeff HostetlerMar 1, 2022
  16. Tao KlerksMar 1, 2022
  17. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Mar 1, 2022
  18. Junio C HamanoMar 1, 2022
  19. Tao KlerksMar 1, 2022
  20. Tao KlerksMar 1, 2022
  21. Junio C HamanoMar 1, 2022
  22. 0/2 Reduce explicit sleep calls in t7063 untracked cache testsTao Klerks via GitGitGadget, Mar 2, 2022
  23. 1/2 t/helper/test-chmtime: update mingw to support chmtime on directoriesTao Klerks via GitGitGadget, Mar 2, 2022
  24. Johannes SchindelinMar 9, 2022
  25. 2/2 t7063: mtime-mangling instead of delays in untracked cache testingTao Klerks via GitGitGadget, Mar 2, 2022
  26. Johannes SchindelinMar 9, 2022
  27. Tao KlerksMar 5, 2022
  28. Junio C HamanoMar 6, 2022
  29. Tao KlerksMar 7, 2022
  30. Junio C HamanoMar 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.