git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 00/22] git-p4: Various code tidy-ups

From
Tao Klerks <tao@klerks.biz>
Date
Apr 2, 2022, 12:14 UTC
Message-ID
<CAPMMpohZxpMFc-rVE96QbeGzN6NdF5CdYVp6FLrHD6Ngi=mu4A@mail.gmail.com>
In-Reply-To
<20220210164627.279520-1-jholdsworth@nvidia.com>
On Thu, Feb 10, 2022 at 5:46 PM Joel Holdsworth <jholdsworth@nvidia.com> wrote:
Show 18 quoted lines
>
> This patch set contains multiple patches to improve consistency and
> tidyness of the git-p4 script's code style.
>
> Many of these patches have been driven by the guidlines contained in the
> Python PEP8 "Style Guide for Python Code" and were applied using a
> mixture of human intervention, and tools including autopep8 and
> pycodestyle.
>
> This patch-set stops short of bringing git-p4 into full PEP8 compliance,
> most notably in regard to the following items:
>
>   - There is no patch to apply the recommended column limit of
>     79-characters,
>   - There is no patch to correct hanging indents of multi-line
>     declarations such as multi-line function delcarations, function
>     invocations, etc.
>

I love the direction of cleaning this up and making it compliant with *something* :)

I've tried to run pylint on the previous state and state after this patch, but unfortunately there's a *lot* of noise either way - from all the "pylint: disable" entries in the script I have to assume that at some point it was compliant with *some* pylint version, but at the moment it's very far from any sort of compliance with checks I can run (both before and after this patchset).

I have a few questions about the changes - I don't think they're
specific to any single commit so I'll list them here:
1) Is there a tool that can be used to check for PEP8 compliance, and
shows only the two remaining issues you highlighted above?
2) What is the relationship between "git-p4" and "git-p4.py"? Before
this patchset they are identical except for the shebang line, after
this patchset all these fixes are applied only to one of them. I
assume the changes should be made to both files in a coordinated
fashion?
3) Which of the "pylint: disable" entries remain meaningful after
these changes, if any? I imagine "disable=wrong-import-order" for
example makes no sense?

I personally have an interest in making sure this script keeps running correctly under python2, so I plan to test this when I can. I imagine this is already accounted for in the t98xx suite somewhere, but I haven't found it.

Thanks, Tao

Previous: Joel HoldsworthNext: Tao Klerks
Message 24 of 31 in “git-p4: Various code tidy-ups”
  1. 00/22 git-p4: Various code tidy-upsJoel Holdsworth, Feb 10, 2022
  2. 01/22 git-p4: add blank lines between functions and class definitionsJoel Holdsworth, Feb 10, 2022
  3. 02/22 git-p4: remove unneeded semicolons from statementsJoel Holdsworth, Feb 10, 2022
  4. 03/22 git-p4: indent with 4-spacesJoel Holdsworth, Feb 10, 2022
  5. 05/22 git-p4: convert descriptive class and function comments into docstringsJoel Holdsworth, Feb 10, 2022
  6. 04/22 git-p4: improve consistency of docstring formattingJoel Holdsworth, Feb 10, 2022
  7. 06/22 git-p4: remove commented codeJoel Holdsworth, Feb 10, 2022
  8. 07/22 git-p4: sort and de-duplcate pylint disable listJoel Holdsworth, Feb 10, 2022
  9. 09/22 git-p4: remove spaces around default argumentsJoel Holdsworth, Feb 10, 2022
  10. 08/22 git-p4: remove padding from lists, tuples and function argumentsJoel Holdsworth, Feb 10, 2022
  11. 10/22 git-p4: removed brackets when assigning multiple return valuesJoel Holdsworth, Feb 10, 2022
  12. 12/22 git-p4: remove extraneous spaces before function argumentsJoel Holdsworth, Feb 10, 2022
  13. 11/22 git-p4: place a single space after every commaJoel Holdsworth, Feb 10, 2022
  14. 13/22 git-p4: remove redundant backslash-continuations inside bracketsJoel Holdsworth, Feb 10, 2022
  15. 14/22 git-p4: remove spaces between dictionary keys and colonsJoel Holdsworth, Feb 10, 2022
  16. 15/22 git-p4: ensure every comment has a single #Joel Holdsworth, Feb 10, 2022
  17. 16/22 git-p4: ensure there is a single space around all operatorsJoel Holdsworth, Feb 10, 2022
  18. 17/22 git-p4: normalize indentation of lines in conditionalsJoel Holdsworth, Feb 10, 2022
  19. 19/22 git-p4: only seperate code blocks by a single empty lineJoel Holdsworth, Feb 10, 2022
  20. 20/22 git-p4: move inline comments to line aboveJoel Holdsworth, Feb 10, 2022
  21. 22/22 git-p4: sort importsJoel Holdsworth, Feb 10, 2022
  22. 18/22 git-p4: compare to singletons with "is" and "is not"Joel Holdsworth, Feb 10, 2022
  23. 21/22 git-p4: seperate multiple statements onto seperate linesJoel Holdsworth, Feb 10, 2022
  24. Tao KlerksApr 2, 2022
  25. Tao KlerksApr 2, 2022
  26. Joel HoldsworthApr 4, 2022
  27. Tao KlerksApr 5, 2022
  28. Tao KlerksApr 5, 2022
  29. Joel HoldsworthApr 5, 2022
  30. Tao KlerksApr 5, 2022
  31. Tao KlerksApr 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.