git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 13/22] git-p4: remove redundant backslash-continuations inside brackets

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Feb 10, 2022, 16:46 UTC
Message-ID
<20220210164627.279520-14-jholdsworth@nvidia.com>
In-Reply-To
<20220210164627.279520-1-jholdsworth@nvidia.com>

PEP8 recommends that backslash line continuations should only be used for line-breaks outside parentheses.

This recommendation is described in the "Maximum Line Length" section:
https://www.python.org/dev/peps/pep-0008/#maximum-line-length
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
 git-p4.py | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 862dc4ca00..471a26744a 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2201,13 +2201,13 @@ def applyCommit(self, id):
                 print("  " + self.clientPath)
                 print("")
                 print("To submit, use \"p4 submit\" to write a new description,")
-                print("or \"p4 submit -i <%s\" to use the one prepared by" \
+                print("or \"p4 submit -i <%s\" to use the one prepared by"
                       " \"git p4\"." % fileName)
                 print("You can delete the file \"%s\" when finished." % fileName)
 
                 if self.preserveUser and p4User and not self.p4UserIsMe(p4User):
-                    print("To preserve change ownership by user %s, you must\n" \
-                          "do \"p4 change -f <change>\" after submitting and\n" \
+                    print("To preserve change ownership by user %s, you must\n"
+                          "do \"p4 change -f <change>\" after submitting and\n"
                           "edit the User field.")
                 if pureRenameCopy:
                     print("After submitting, renamed files must be re-synced.")
@@ -2350,7 +2350,7 @@ def exportGitTags(self, gitTags):
             if self.dry_run:
                 print("Would create p4 label %s for tag" % name)
             elif self.prepare_p4_only:
-                print("Not creating p4 label %s for tag due to option" \
+                print("Not creating p4 label %s for tag due to option"
                       " --prepare-p4-only" % name)
             else:
                 p4_write_pipe(["label", "-i"], labelTemplate)
@@ -2515,12 +2515,12 @@ def run(self, args):
         if not self.no_verify:
             try:
                 if not run_git_hook("p4-pre-submit"):
-                    print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nYou can skip " \
-                        "this pre-submission check by adding\nthe command line option '--no-verify', " \
+                    print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nYou can skip "
+                        "this pre-submission check by adding\nthe command line option '--no-verify', "
                         "however,\nthis will also skip the p4-changelist hook as well.")
                     sys.exit(1)
             except Exception as e:
-                print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nThe hook failed "\
+                print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nThe hook failed "
                     "with the error '{0}'".format(e.message))
                 sys.exit(1)
 
@@ -2543,7 +2543,7 @@ def run(self, args):
                 applied.append(commit)
                 if self.prepare_p4_only:
                     if i < last:
-                        print("Processing only the first commit due to option" \
+                        print("Processing only the first commit due to option"
                                 " --prepare-p4-only")
                     break
             else:
@@ -4206,7 +4206,7 @@ def run(self, args):
             if not self.cloneBare:
                 system(["git", "checkout", "-f"])
         else:
-            print('Not checking out any branch, use ' \
+            print('Not checking out any branch, use '
                   '"git checkout -q -b master <branch>"')
 
         # auto-set this variable if invoked with --use-client-spec
-- 
2.35.GIT
Previous: Joel HoldsworthNext: Joel Holdsworth
Message 14 of 31 in “git-p4: Various code tidy-ups”
  1. 00/22 git-p4: Various code tidy-upsJoel Holdsworth, Feb 10, 2022
  2. 01/22 git-p4: add blank lines between functions and class definitionsJoel Holdsworth, Feb 10, 2022
  3. 02/22 git-p4: remove unneeded semicolons from statementsJoel Holdsworth, Feb 10, 2022
  4. 03/22 git-p4: indent with 4-spacesJoel Holdsworth, Feb 10, 2022
  5. 05/22 git-p4: convert descriptive class and function comments into docstringsJoel Holdsworth, Feb 10, 2022
  6. 04/22 git-p4: improve consistency of docstring formattingJoel Holdsworth, Feb 10, 2022
  7. 06/22 git-p4: remove commented codeJoel Holdsworth, Feb 10, 2022
  8. 07/22 git-p4: sort and de-duplcate pylint disable listJoel Holdsworth, Feb 10, 2022
  9. 09/22 git-p4: remove spaces around default argumentsJoel Holdsworth, Feb 10, 2022
  10. 08/22 git-p4: remove padding from lists, tuples and function argumentsJoel Holdsworth, Feb 10, 2022
  11. 10/22 git-p4: removed brackets when assigning multiple return valuesJoel Holdsworth, Feb 10, 2022
  12. 12/22 git-p4: remove extraneous spaces before function argumentsJoel Holdsworth, Feb 10, 2022
  13. 11/22 git-p4: place a single space after every commaJoel Holdsworth, Feb 10, 2022
  14. 13/22 git-p4: remove redundant backslash-continuations inside bracketsJoel Holdsworth, Feb 10, 2022
  15. 14/22 git-p4: remove spaces between dictionary keys and colonsJoel Holdsworth, Feb 10, 2022
  16. 15/22 git-p4: ensure every comment has a single #Joel Holdsworth, Feb 10, 2022
  17. 16/22 git-p4: ensure there is a single space around all operatorsJoel Holdsworth, Feb 10, 2022
  18. 17/22 git-p4: normalize indentation of lines in conditionalsJoel Holdsworth, Feb 10, 2022
  19. 19/22 git-p4: only seperate code blocks by a single empty lineJoel Holdsworth, Feb 10, 2022
  20. 20/22 git-p4: move inline comments to line aboveJoel Holdsworth, Feb 10, 2022
  21. 22/22 git-p4: sort importsJoel Holdsworth, Feb 10, 2022
  22. 18/22 git-p4: compare to singletons with "is" and "is not"Joel Holdsworth, Feb 10, 2022
  23. 21/22 git-p4: seperate multiple statements onto seperate linesJoel Holdsworth, Feb 10, 2022
  24. Tao KlerksApr 2, 2022
  25. Tao KlerksApr 2, 2022
  26. Joel HoldsworthApr 4, 2022
  27. Tao KlerksApr 5, 2022
  28. Tao KlerksApr 5, 2022
  29. Joel HoldsworthApr 5, 2022
  30. Tao KlerksApr 5, 2022
  31. Tao KlerksApr 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.