Re: [PATCH] git-am: Handle "git show" output correctly
- From
Dan Johnson <computerdruid@gmail.com>
- Date
- Sep 12, 2012, 21:26 UTC
- Message-ID
- <CAPBPrntHOpDaH3cSNiKKxVJDbZTpPrLc99TgPM_GdoXecUvs9w@mail.gmail.com>
- In-Reply-To
- <7vpq5raqiq.fsf@alter.siamese.dyndns.org>
On Wed, Sep 12, 2012 at 5:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Peter Jones <pjones@redhat.com> writes: > >> Well, if that happens, maybe we could regexp match on >> "[[:alnum:]_-]+: /someexprthatlookslikeanemailaddress/" ? > > I doubt that would be even reliably done. > >> But we could >> also just wait to cross that bridge until we get to it? > > Not really. If we start encouraging people to use "git show" output > as a kosher input to "am", we would have to support such use > forever, and we end up painting ourselves in a corner we cannot get > out of easily.
If git am emitted a warning when accepting "git show" output, it seems like it would support Peter's use-case without encouraging bad behavior?
-- -Dan