git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [git-am] Handle "git show" output correctly

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 12, 2012, 17:32 UTC
Message-ID
<7v392ndu59.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpqbohbz11h.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 9 quoted lines
> Peter Jones <pjones@redhat.com> writes:
>
>> Subject: [PATCH] [git-am] Handle "git show" output correctly
>
> The convention in Git is "<subsystem>: <summary of change>" (i.e. no
> brackets around git-am, just am: and no capital for Handle).
>
> My other concerns (name of stgit, multi-lines subject lines and lack of
> documentation) still hold.

We do not want to apply "git show" output that munges the log message, period.

If you want to give patches to somebody (or to yourself) via e-mail or via sneaker-net, "git format-patch" is there for you. Do not butcher "am" to accept a format that is not meant for patch transport in the first place.

If you want to screw something in to your shelf, you would use a screw and a screwdriver. You do not try to hammer a nail using your screwdriver, find that the screwdriver is not very useful as a hammer and modify the screwdriver to hit your nail.

Previous: Matthieu MoyNext: Peter Jones
Message 6 of 21 in “Handle "git show" output correctly.”
  1. Handle "git show" output correctly.Peter Jones, Sep 12, 2012
  2. Handle "git show" output correctly.Peter Jones, Sep 12, 2012
  3. Matthieu MoySep 12, 2012
  4. [git-am] Handle "git show" output correctlyPeter Jones, Sep 12, 2012
  5. Matthieu MoySep 12, 2012
  6. Junio C HamanoSep 12, 2012
  7. Peter JonesSep 12, 2012
  8. Junio C HamanoSep 12, 2012
  9. Handle "git show" output correctly.Peter Jones, Sep 12, 2012
  10. Matthieu MoySep 12, 2012
  11. Peter JonesSep 12, 2012
  12. git-am: Handle "git show" output correctlyPeter Jones, Sep 12, 2012
  13. Junio C HamanoSep 12, 2012
  14. Peter JonesSep 12, 2012
  15. git-am: Handle "git show" output correctlyPeter Jones, Sep 12, 2012
  16. Junio C HamanoSep 12, 2012
  17. Dan JohnsonSep 12, 2012
  18. Junio C HamanoSep 12, 2012
  19. Dan JohnsonSep 12, 2012
  20. Junio C HamanoSep 12, 2012
  21. Andreas EricssonSep 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.