Re: [GSoC][PATCH 1/6] reftable: clean up reftable/pq.c

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 6, 2024, 16:23 UTC
Message-ID: <CAP8UFD3xepwyjo1c7LvazpNr-M1BDgUBMbjghgtHbyv0syP6mw@mail.gmail.com>
In-Reply-To: <CA+J6zkTMgvvSbUC5t39s4U80MAk+og5ENQf3StdJ2-MM82MAZA@mail.gmail.com>

On Thu, Jun 6, 2024 at 12:07 PM Chandra Pratap <chandrapratap3519@gmail.com> wrote:

Show 18 quoted lines

>
> On Thu, 6 Jun 2024 at 14:21, Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > On Thu, Jun 6, 2024 at 9:57 AM Chandra Pratap
> > <chandrapratap3519@gmail.com> wrote:
> > >
> > > According to Documentation/CodingGuidelines, control-flow statements
> > > with a single line as their body must omit curly braces. Make
> > > reftable/pq.c conform to this guideline. Besides that, remove
> > > unnecessary newlines and variable assignment.
> >
> > A commit subject like "reftable/pq: remove unnecessary curly braces"
> > might be a bit more specific.
>
> There are other forms of cleanup also being performed, like removing
> unnecessary newlines and variable assignment. Would it still be okay
> to sweep it all under 'removing unnecessary braces'?

I think the removal of unnecessary braces is the main change and other changes are made while at it, so I think it's Ok.