Re: [GSoC][PATCH v5 0/7] t: port reftable/pq_test.c to the unit testing framework

>
> Chandra Pratap <chandrapratap3519@gmail.com> writes:
>
> > The reftable library comes with self tests, which are exercised
> > as part of the usual end-to-end tests and are designed to
> > observe the end-user visible effects of Git commands. What it
> > exercises, however, is a better match for the unit-testing
> > framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests',
> > 2023-12-09), which is designed to observe how low level
> > implementation details, at the level of sequences of individual
> > function calls, behave.
> >
> > Hence, port reftable/pq_test.c to the unit testing framework and
> > improve upon the ported test. The first two patches in the series
> > are preparatory cleanup, the third patch moves the test to the unit
> > testing framework, and the rest of the patches improve upon the
> > ported test.
> >
> > Mentored-by: Patrick Steinhardt <ps@pks.im>
> > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> > Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
> >
> > ---
> > Changes in v5:
> > - Rebase the branch on top of the  latest master branch
>
> If you need to perform this rebase, please say _why_ you are
> rebasing.
>
> "A new rc was tagged so I rebased" is *not* a good reason.
>
> "I wanted to use that new feature that was merged to 'master'
> recently, which was not available when I wrote the previous
> iteration of this series, hence I rebased" is a very good reason.
>
> "Since I wrote the previous iteration, other unit test topics have
> graduated, so there are trivial conflicts in Makefile when merging
> this topic" is usually not a good reason, especially when the same
> conflicts with these other unit test topics are already resolved
> when your previous iteration is merged to 'seen'.
>
> If there isn't a reason worth mentioning why you are rebasing, then
> please do not rebase.  It is distracting.

> > - Rename tests according to unit-tests' conventions
> > - remove 'pq_test_main()' from reftable/reftable-test.h
> >
> > CI/PR for v5: https://github.com/gitgitgadget/git/pull/1745
>
> By the way, I still haven't got any answer to a question I asked
> long ago on this series, wrt possibly unifying this pq and another
> pq we already use elsewhere in our codebase.  If we are butchering
> what we borrowed from elsewhere and store in reftable/. directory
> and taking responsibility of maintaining it ourselves, we probably
> should consider larger refactoring and cleaning up, and part of it
> we may end up discarding this pq implementation, making the unit
> testing on it a wasted effort.
>
> Thanks.
>