Re: [PATCH 2/2] help: include unsafe SHA-1 build info in version

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 29, 2025, 08:42 UTC
Message-ID: <CAP8UFD3tXtoCcCt0+=SVh76JNvRGL7DOH9Td3igKn6AS07bfiw@mail.gmail.com>
In-Reply-To: <20250328170121.157563-3-jltobler@gmail.com>

On Fri, Mar 28, 2025 at 6:05 PM Justin Tobler <jltobler@gmail.com> wrote:

Show 23 quoted lines

>
> In 06c92dafb8 (Makefile: allow specifying a SHA-1 for non-cryptographic
> uses, 2024-09-26), support for unsafe SHA-1 is added. Add the unsafe
> SHA-1 build info to `git version --build-info` and update corresponding
> documentation.
>
> Signed-off-by: Justin Tobler <jltobler@gmail.com>
> ---
>  Documentation/git-version.adoc | 3 +++
>  help.c                         | 8 ++++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/Documentation/git-version.adoc b/Documentation/git-version.adoc
> index 80fa7754a6..53c8ba74c1 100644
> --- a/Documentation/git-version.adoc
> +++ b/Documentation/git-version.adoc
> @@ -22,6 +22,9 @@ OPTIONS
>  --build-options::
>         Include additional information about how git was built for diagnostic
>         purposes.
> ++
> +If built to use a faster SHA-1 implementation for non-cryptographic purposes,
> +the implmentation used is denoted as "unsafe-SHA-1".

s/the implmentation used/that implementation/