Re: [PATCH v3 0/2] help: include SHA build options in version info

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 4, 2025, 11:06 UTC
Message-ID: <CAP8UFD2a2hA5CEYgr9i5jtw+k8U9gu=Jb01x=W1zekSRBy7B8A@mail.gmail.com>
In-Reply-To: <Z--kT3fIvz8k7h96@pks.im>

On Fri, Apr 4, 2025 at 11:20 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 20 quoted lines

>
> On Thu, Apr 03, 2025 at 09:05:27AM -0500, Justin Tobler wrote:
> > Greetings,
> >
> > Additional information regarding how Git was built can be found via the
> > `--build-options` flag for git-version(1). This currently does not
> > include information about the SHA-1 and SHA-256 implementations Git is
> > built with.
> >
> > This short series adds build option info for the SHA-1, SHA-256, and
> > non-crypto-SHA-1 (if any) implementations which may be useful for
> > diagnostic purposes
> >
> > Changes since V2:
> >
> >   - Updates to documentation to provide additional context.
> >
> >   - Inlined `get_sha_impl()` function.
>
> Thanks, I'm happy with this version.

I am fine with it as well. Thanks.