Re: [GSoC][PATCH] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 7, 2024, 08:41 UTC
Message-ID: <CAP8UFD3aTC_s8BgXYDcM_ecjMQmRsMiNMJxgXD2FLYvt26OwWQ@mail.gmail.com>
In-Reply-To: <CAP8UFD2eUxrr2Z0etZKbakXEB5VAfXH63jLhfAYJyOxBwvJPEQ@mail.gmail.com>

On Fri, Jun 7, 2024 at 10:36 AM Christian Couder <christian.couder@gmail.com> wrote:

Show 6 quoted lines

>
> On Fri, Jun 7, 2024 at 10:31 AM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > On Fri, Jun 7, 2024 at 1:35 AM Ghanshyam Thakkar
> > <shyamthakkar001@gmail.com> wrote:

Show 13 quoted lines

> > > static void check_each(struct oidtree *ot, char *query, ...)
> > > {
> > >         struct object_id oid;
> > >         struct strvec hexes = STRVEC_INIT;
> > >         struct cb_data cb_data;
> > >         const char *arg;
> > >         int i = 0;
>
> ... and above only:
>
>         struct object_id oid;
>         const char *arg;
>         struct expected_hex_iter hex_iter = { 0 };

Actually I think it should be:

        struct expected_hex_iter hex_iter = { .hexes = STRVEC_INIT };